Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(theme:modal): removed nzComponentParams #1615

Merged
merged 2 commits into from
Jul 19, 2023
Merged

fix(theme:modal): removed nzComponentParams #1615

merged 2 commits into from
Jul 19, 2023

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Jul 19, 2023

  • 保留 nzComponentParams 原有风格，其实这个方案还蛮好用的，但依然可以通过 @Inject(NZ_MODAL_DATA) 获取 ng-zorro 的标准写法

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@cipchk
fix(theme:modal): removed nzComponentParams
ccf7ff9 
- 保留 nzComponentParams 原有风格，其实这个方案还蛮好用的，但依然可以通过 @Inject(NZ_MODAL_DATA) 获取 ng-zorro 的标准写法
@cipchk
docs: update
9a0fc4b
@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Jul 19, 2023 •
edited
Loading

Preview is ready!

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #1615 (d77adc0) into master (bcd60e6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head d77adc0 differs from pull request most recent head 9a0fc4b. Consider uploading reports for the commit 9a0fc4b to get more accurate results

@@           Coverage Diff           @@
##           master    #1615   +/-   ##
=======================================
  Coverage   95.51%   95.51%           
=======================================
  Files         277      277           
  Lines        8523     8525    +2     
  Branches     1667     1668    +1     
=======================================
+ Hits         8141     8143    +2     
  Misses        317      317           
  Partials       65       65
Impacted Files Coverage Δ
packages/theme/src/services/modal/modal.helper.ts 79.24% <100.00%> (+0.81%) ⬆️

@cipchk cipchk merged commit 45863a1 into master Jul 19, 2023
8 checks passed
@cipchk cipchk deleted the issues-zorro-latest branch July 19, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cipchk @ng-alain-bot